#37 improve UI when an error occurs during page load from checker

Open
opened 9 months ago by hz · 1 comments
hz commented 9 months ago

When the checker is loading a page or trying to find the question that someone submitted to, there are rare cases where an error can occur. Right now, the UI continues to report that “your submission is currently being checker” in that case, which is not true (since the error means we can’t even start checking in that case).

Example: 6.009 staff trying to submit ‘q000000’ as a student, but the student doesn’t actually have that box because cs_post_load removes it from their view.

Server reports:

Process Process-173:
Traceback (most recent call last):
  File "/usr/lib/python3.5/multiprocessing/process.py", line 249, in _bootstrap
    self.run()
  File "/usr/lib/python3.5/multiprocessing/process.py", line 93, in run
    self._target(*self._args, **self._kwargs)
  File "checker.py", line 148, in do_check
    question, args = namemap[name]
KeyError: 'q000000'
When the checker is loading a page or trying to find the question that someone submitted to, there are rare cases where an error can occur. Right now, the UI continues to report that "your submission is currently being checker" in that case, which is not true (since the error means we can't even start checking in that case). Example: 6.009 staff trying to submit 'q000000' as a student, but the student doesn't actually have that box because cs_post_load removes it from their view. Server reports: ```nohighlight Process Process-173: Traceback (most recent call last): File "/usr/lib/python3.5/multiprocessing/process.py", line 249, in _bootstrap self.run() File "/usr/lib/python3.5/multiprocessing/process.py", line 93, in run self._target(*self._args, **self._kwargs) File "checker.py", line 148, in do_check question, args = namemap[name] KeyError: 'q000000' ```
hz added the
beginner friendly
label 9 months ago
hz added the
ui/ux
label 9 months ago
hz commented 9 months ago
Owner

I implemented a temporary fix for this, but there is still work to be done here. Rather than the catch-all that’s currently implemented, it would be good to carefully try the different pieces associated with loading a page so we can give a better error message than “an unexpected error occurred”.

I implemented a temporary fix for this, but there is still work to be done here. Rather than the catch-all that's currently implemented, it would be good to carefully try the different pieces associated with loading a page so we can give a better error message than "an unexpected error occurred".
Sign in to join this conversation.
No Milestone
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.